[Telepathy-commits] [telepathy-gabble/master] Silence the generation of gabble-signals-marshal.list

Will Thompson will.thompson at collabora.co.uk
Mon Feb 9 07:56:01 PST 2009


This rule fires every time, because if no source files have changed then
gabble-signals-marshal.list doesn't change so Make still thinks it's
old. The alternatives are to move the "build to temporary file and only
mv if it's changed" thing to building gabble-signals-marshal.h (which
would then run every time instead), or to touch the list even when it
hasn't changed (which would cause the whole of gabble to be rebuilt
whenever you change any source file).

I assert that this is better than rebuilding the whole of gabble. :-)
---
 src/Makefile.am |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index defdbb7..7b8edf5 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -167,11 +167,11 @@ $(top_builddir)/lib/gibber/libgibber.la:
 .PHONY: $(top_builddir)/lib/gibber/libgibber.la
 
 gabble-signals-marshal.list: $(libgabble_convenience_la_SOURCES) Makefile.am
-	( cd $(srcdir) && \
+	@( cd $(srcdir) && \
 	sed -n -e 's/.*gabble_marshal_\([[:upper:][:digit:]]*__[[:upper:][:digit:]_]*\).*/\1/p' \
 	$(libgabble_convenience_la_SOURCES) ) \
 	| sed -e 's/__/:/' -e 'y/_/,/' | sort -u > $@.tmp
-	if cmp -s $@.tmp $@; then \
+	@if cmp -s $@.tmp $@; then \
 		rm $@.tmp; \
 	else \
 		mv $@.tmp $@; \
-- 
1.5.6.5



More information about the telepathy-commits mailing list