[Telepathy-commits] [telepathy-mission-control/master] Set the GError when returning FALSE

Alberto Mardegan alberto.mardegan at nokia.com
Thu Feb 12 02:11:40 PST 2009


---
 src/mcd-account.c |   14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/mcd-account.c b/src/mcd-account.c
index ff22b33..777e993 100644
--- a/src/mcd-account.c
+++ b/src/mcd-account.c
@@ -1194,10 +1194,20 @@ mcd_account_set_parameters (McdAccount *account, GHashTable *params,
     gboolean reset_connection;
 
     g_debug ("%s called", G_STRFUNC);
-    if (!priv->manager && !load_manager (account)) return FALSE;
+    if (G_UNLIKELY (!priv->manager && !load_manager (account)))
+    {
+        g_set_error (error, TP_ERRORS, TP_ERROR_INVALID_ARGUMENT,
+                     "Manager %s not found", priv->manager_name);
+        return FALSE;
+    }
 
     param = mcd_manager_get_parameters (priv->manager, priv->protocol_name);
-    if (G_UNLIKELY (!param)) return FALSE;
+    if (G_UNLIKELY (!param))
+    {
+        g_set_error (error, TP_ERRORS, TP_ERROR_INVALID_ARGUMENT,
+                     "Protocol %s not found", priv->protocol_name);
+        return FALSE;
+    }
 
     reset_connection = FALSE;
     while (param->name != NULL)
-- 
1.5.6.5




More information about the telepathy-commits mailing list