[Telepathy-commits] [telepathy-glib/master] Revise comment about permissive boolean parsing, as per wjt's review

Simon McVittie simon.mcvittie at collabora.co.uk
Fri Feb 13 07:44:10 PST 2009


---
 telepathy-glib/connection-manager.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/telepathy-glib/connection-manager.c b/telepathy-glib/connection-manager.c
index 33af2ab..907e932 100644
--- a/telepathy-glib/connection-manager.c
+++ b/telepathy-glib/connection-manager.c
@@ -826,8 +826,10 @@ parse_default_value (GValue *value,
         return TRUE;
 
       /* In telepathy-glib < 0.7.UNRELEASED we accepted true and false in
-       * any case combination, so on error, let's fall back to more lenient
-       * parsing */
+       * any case combination, 0, and 1. The desktop file spec specifies
+       * "true" and "false" only, while GKeyFile currently accepts 0 and 1 too.
+       * So, on error, let's fall back to more lenient parsing that explicitly
+       * allows everything we historically allowed. */
       g_error_free (error);
       s = g_key_file_get_value (file, group, key, NULL);
 
-- 
1.5.6.5



More information about the telepathy-commits mailing list