[Telepathy-commits] [telepathy-gabble/master] Add FIXMEs for safe but unpleasant g_idle_add()s.

Will Thompson will.thompson at collabora.co.uk
Mon Feb 16 11:45:04 PST 2009


---
 src/jingle-session.c |    1 +
 src/media-stream.c   |    4 +++-
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/jingle-session.c b/src/jingle-session.c
index c034a7e..8074a9c 100644
--- a/src/jingle-session.c
+++ b/src/jingle-session.c
@@ -542,6 +542,7 @@ fire_idle_content_reject (GabbleJingleSession *sess, const gchar *name,
   ctx->name = g_strdup (name);
   ctx->creator = g_strdup (creator);
 
+  /* FIXME: add API for ordering IQs rather than using g_idle_add. */
   g_idle_add (idle_content_reject, ctx);
 }
 
diff --git a/src/media-stream.c b/src/media-stream.c
index 2fe72e0..2ae1fc6 100644
--- a/src/media-stream.c
+++ b/src/media-stream.c
@@ -220,7 +220,9 @@ gabble_media_stream_constructor (GType type, guint n_props,
       /* MediaStream is created as soon as GabbleJingleContent is
        * created, but we want to let it parse the initiation (if
        * initiated by remote end) before we pick up initial
-       * codecs and candidates. */
+       * codecs and candidates.
+       * FIXME: add API for ordering IQs rather than using g_idle_add.
+       */
       priv->initial_getter_id =
           g_idle_add (_get_initial_codecs_and_candidates, stream);
     }
-- 
1.5.6.5




More information about the telepathy-commits mailing list