[Telepathy-commits] [telepathy-mission-control/master] Avoid copying and leaking the channel properties

Alberto Mardegan alberto.mardegan at nokia.com
Tue Feb 17 03:48:17 PST 2009


---
 src/mcd-connection.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mcd-connection.c b/src/mcd-connection.c
index 2eeb59c..3503775 100644
--- a/src/mcd-connection.c
+++ b/src/mcd-connection.c
@@ -1358,7 +1358,7 @@ static void get_all_requests_cb (TpProxy *proxy, GHashTable *properties,
 
         va = g_ptr_array_index (channels, i);
         object_path = g_value_get_boxed (va->values);
-        channel_props = g_value_dup_boxed (va->values + 1);
+        channel_props = g_value_get_boxed (va->values + 1);
         /* find the McdChannel */
         /* NOTE: we cannot move the mcd_operation_get_missions() call out of
          * the loop, because mcd_dispatcher_send() can cause the channel to be
-- 
1.5.6.5




More information about the telepathy-commits mailing list