[Telepathy-commits] [telepathy-gabble/master] GabbleJingleSession: comment a non-subclass-safe call to g_object_new

Simon McVittie simon.mcvittie at collabora.co.uk
Wed Feb 25 04:53:30 PST 2009


---
 src/jingle-session.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/jingle-session.c b/src/jingle-session.c
index 4328145..d7e9711 100644
--- a/src/jingle-session.c
+++ b/src/jingle-session.c
@@ -569,6 +569,9 @@ create_content (GabbleJingleSession *sess, GType content_type,
   GabbleJingleContent *c;
 
   DEBUG ("session creating new content type, conn == %p, jf == %p", priv->conn, priv->conn->jingle_factory);
+
+  /* FIXME: media-type is introduced by GabbleJingleMediaRTP, not by the
+   * superclass, so this call is unsafe in the general case */
   c = g_object_new (content_type,
                     "connection", priv->conn,
                     "session", sess,
-- 
1.5.6.5




More information about the telepathy-commits mailing list