[Telepathy-commits] [telepathy-glib/master] Remove FIXME about tp_asv_get_boolean accepting ints

Will Thompson will.thompson at collabora.co.uk
Fri Jan 2 15:40:00 PST 2009


If we want to make it more tolerant in the future, we can do so, but it
doesn't seem necessary.  In the integer case, the tolerance is needed
for glib because it doesn't have 16-bit ints, and to make short Python
scripts easier.  The only language I can think of where treating ints as
bools would be useful is Perl, but since there are only two boolean
values forcing people to use magic DBus constants in that case isn't so
bad.
---
 telepathy-glib/dbus.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/telepathy-glib/dbus.c b/telepathy-glib/dbus.c
index d69b75c..2426e9b 100644
--- a/telepathy-glib/dbus.c
+++ b/telepathy-glib/dbus.c
@@ -1001,8 +1001,6 @@ tp_dbus_daemon_class_init (TpDBusDaemonClass *klass)
  *
  * Otherwise return %FALSE, and set *@valid to %FALSE if @valid is not %NULL.
  *
- * (FIXME: should we also allow 'i' and 'u' with nonzero <=> True?)
- *
  * Returns: a boolean value for @key
  * Since: 0.7.9
  */
-- 
1.5.6.5



More information about the Telepathy-commits mailing list