[Telepathy-commits] [telepathy-spec/master] Make Unix_Timestamp64 signed

[Simon McVittie]

This is technically an ABI break, but so far the only stable interfaces
that use it do so in an a{sv}, where implementations should be permissive
about types (telepathy-glib is, via the tp_asv_get_* functions).
---
 spec/Channel_Dispatcher.xml         |    4 ++--
 spec/Channel_Interface_Messages.xml |    4 ++--
 spec/Channel_Request.xml            |    2 +-
 spec/Channel_Type_File_Transfer.xml |    2 +-
 spec/generic-types.xml              |    6 +++---
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/spec/Channel_Dispatcher.xml b/spec/Channel_Dispatcher.xml
index 2c07305..c77873d 100644
--- a/spec/Channel_Dispatcher.xml
+++ b/spec/Channel_Dispatcher.xml
@@ -160,7 +160,7 @@
         </tp:docstring>
       </arg>
 
-      <arg direction="in" name="User_Action_Time" type="t"
+      <arg direction="in" name="User_Action_Time" type="x"
         tp:type="Unix_Timestamp64">
         <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
           <p>The time at which user action occurred, or 0 if this channel
@@ -280,7 +280,7 @@
         </tp:docstring>
       </arg>
 
-      <arg direction="in" name="User_Action_Time" type="t"
+      <arg direction="in" name="User_Action_Time" type="x"
         tp:type="Unix_Timestamp64">
         <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
           <p>The time at which user action occurred, or 0 if this channel
diff --git a/spec/Channel_Interface_Messages.xml b/spec/Channel_Interface_Messages.xml
index 1078504..463aed1 100644
--- a/spec/Channel_Interface_Messages.xml
+++ b/spec/Channel_Interface_Messages.xml
@@ -252,13 +252,13 @@ USA.</p>
               the mid: and cid: URI schemes. If omitted, there is no suitable
               token.</dd>
 
-            <dt>message-sent (t - <tp:type>Unix_Timestamp64</tp:type>)</dt>
+            <dt>message-sent (x - <tp:type>Unix_Timestamp64</tp:type>)</dt>
             <dd>The time the message was sent (if unavailable, the time
               it arrived at a central server MAY be used). Omitted if no
               reasonable approximation is available; SHOULD always be present
               on outgoing messages.</dd>
 
-            <dt>message-received (t - <tp:type>Unix_Timestamp64</tp:type>)</dt>
+            <dt>message-received (x - <tp:type>Unix_Timestamp64</tp:type>)</dt>
             <dd>The time the message was received locally. SHOULD always
               be present.</dd>
 
diff --git a/spec/Channel_Request.xml b/spec/Channel_Request.xml
index 956eee1..bf1bd38 100644
--- a/spec/Channel_Request.xml
+++ b/spec/Channel_Request.xml
@@ -49,7 +49,7 @@
     </property>
 
     <property name="UserActionTime" tp:name-for-bindings="User_Action_Time"
-      type="t" tp:type="Unix_Timestamp64" access="read">
+      type="x" tp:type="Unix_Timestamp64" access="read">
       <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
         <p>The time at which user action occurred, or 0 if this channel
           request is for some reason not involving user action.</p>
diff --git a/spec/Channel_Type_File_Transfer.xml b/spec/Channel_Type_File_Transfer.xml
index a2432f4..f129c16 100644
--- a/spec/Channel_Type_File_Transfer.xml
+++ b/spec/Channel_Type_File_Transfer.xml
@@ -178,7 +178,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
       </tp:docstring>
     </property>
 
-    <property name="Date" type="t" access="read"
+    <property name="Date" type="x" access="read"
       tp:type="Unix_Timestamp64" tp:name-for-bindings="Date">
       <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
         <p>The last modification time of the file being transferred. This
diff --git a/spec/generic-types.xml b/spec/generic-types.xml
index 227fde1..fba6a9f 100644
--- a/spec/generic-types.xml
+++ b/spec/generic-types.xml
@@ -7,10 +7,10 @@
       (1970-01-01T00:00:00Z)</tp:docstring>
   </tp:simple-type>
 
-  <tp:simple-type name="Unix_Timestamp64" type="t">
-    <tp:docstring>An unsigned 64-bit integer representing time as the number
+  <tp:simple-type name="Unix_Timestamp64" type="x">
+    <tp:docstring>An signed 64-bit integer representing time as the number
       of seconds elapsed since the Unix epoch
-      (1970-01-01T00:00:00Z)</tp:docstring>
+      (1970-01-01T00:00:00Z); negative for times before the epoch</tp:docstring>
 
     <tp:rationale>The Text interface is the only user of Unix_Timestamp so
       far, and we'd like to be Y2038 compatible in future
-- 
1.5.6.5