[telepathy-qt4/master] Fixed bug 20080: KeyFile: "; " as a list may be mis-parsed.

Andre Moreira Magalhaes (andrunko) andre.magalhaes at collabora.co.uk
Tue Jun 30 10:22:28 PDT 2009


Actually this was not a bug, just improving test coverage.
---
 tests/manager-file.cpp                             |    8 ++++++++
 tests/telepathy/managers/test-manager-file.manager |    6 +++++-
 2 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/tests/manager-file.cpp b/tests/manager-file.cpp
index 43be13f..91c3392 100644
--- a/tests/manager-file.cpp
+++ b/tests/manager-file.cpp
@@ -88,6 +88,14 @@ void TestManagerFile::testManagerFile()
     QCOMPARE(param->signature, QString("as"));
     QCOMPARE(param->defaultValue.variant().toStringList(),
              QStringList() << "list\\;of" << "misc");
+    param = getParam(params, "empty-list");
+    QCOMPARE(param->signature, QString("as"));
+    QCOMPARE(param->defaultValue.variant().toStringList(),
+             QStringList());
+    param = getParam(params, "list-of-empty-string");
+    QCOMPARE(param->signature, QString("as"));
+    QCOMPARE(param->defaultValue.variant().toStringList(),
+             QStringList() << QString());
 }
 
 bool containsParam(const ParamSpecList &params, const char *name)
diff --git a/tests/telepathy/managers/test-manager-file.manager b/tests/telepathy/managers/test-manager-file.manager
index e06c1d9..5c1434f 100644
--- a/tests/telepathy/managers/test-manager-file.manager
+++ b/tests/telepathy/managers/test-manager-file.manager
@@ -55,7 +55,11 @@ default-triply-escaped-semicolon-in-list = list\\\;of;misc;
 
 # the value is an empty list
 param-empty-list = as
-default-empty-list = ;
+default-empty-list =
+
+# the value is a list of empty string
+param-list-of-empty-string = as
+default-list-of-empty-string = ;
 
 # this is probably technically a Desktop Entry spec violation?
 # we should be permissive, interpreting this as either "foo\;bar" or "foo;bar"
-- 
1.5.6.5




More information about the telepathy-commits mailing list