[Telepathy-commits] [telepathy-gabble/master] handle_socks5_query_iq: assume mode is 'tcp' is not specified

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Tue Mar 17 09:43:02 PDT 2009


---
 src/bytestream-factory.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/bytestream-factory.c b/src/bytestream-factory.c
index ccb52b7..011ca33 100644
--- a/src/bytestream-factory.c
+++ b/src/bytestream-factory.c
@@ -1101,7 +1101,8 @@ handle_socks5_query_iq (GabbleBytestreamFactory *self,
     }
 
   tmp = lm_message_node_get_attribute (query_node, "mode");
-  if (tp_strdiff (tmp, "tcp"))
+  /* If this attribute is missing, the default value of "tcp" MUST be assumed */
+  if (tmp != NULL && tp_strdiff (tmp, "tcp"))
     {
       DEBUG ("non-TCP SOCKS5 bytestreams are not supported");
       _gabble_connection_send_iq_error (priv->conn, msg,
-- 
1.5.6.5




More information about the telepathy-commits mailing list