[telepathy-gabble/master] 'deny' is NotImplemented on !GTalk.

Will Thompson will.thompson at collabora.co.uk
Fri May 1 13:03:19 PDT 2009


By the definitions of NotImplemented and NotAvailable for CreateChannel,
the former is certainly the right error.
---
 src/roster.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/roster.c b/src/roster.c
index a107511..b970786 100644
--- a/src/roster.c
+++ b/src/roster.c
@@ -2610,8 +2610,7 @@ gabble_roster_request (GabbleRoster *self,
       handle == GABBLE_LIST_HANDLE_DENY &&
       !(self->priv->conn->features & GABBLE_CONNECTION_FEATURES_GOOGLE_ROSTER))
     {
-      /* FIXME: should this be NotImplemented? */
-      g_set_error (&error, TP_ERRORS, TP_ERROR_NOT_AVAILABLE,
+      g_set_error (&error, TP_ERRORS, TP_ERROR_NOT_IMPLEMENTED,
           "This server does not have Google roster extensions, so there's "
           "no deny list");
       goto error;
-- 
1.5.6.5




More information about the telepathy-commits mailing list