[telepathy-mission-control/mission-control-4] Don't close channels on dispose

Sjoerd Simons sjoerd.simons at collabora.co.uk
Wed May 27 06:05:45 PDT 2009


There are various reasons why MCDChannels are disposed, on the current desktop
this is either when a client calls close on the telepathy channel directly or
when disconnecting from a connection. In the first case calling Close makes no
sense (somebody already did this), in the second case it causes troubles when
Close has an extra protocol level meaning. For example when using an IRC proxy,
closing a the group text means parting the channel on irc, this means on
disconnect your proxy will no longer be part of the cahnnel. Which is exactly
what you didn't want :)
---
 src/mcd-channel.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mcd-channel.c b/src/mcd-channel.c
index 6c19819..d18a057 100644
--- a/src/mcd-channel.c
+++ b/src/mcd-channel.c
@@ -637,7 +637,7 @@ _mcd_channel_dispose (GObject * object)
 	return;
 
     priv->is_disposed = TRUE;
-    _mcd_channel_release_tp_channel (MCD_CHANNEL (object), TRUE);
+    _mcd_channel_release_tp_channel (MCD_CHANNEL (object), FALSE);
     G_OBJECT_CLASS (mcd_channel_parent_class)->dispose (object);
 }
 
-- 
1.5.6.5



More information about the telepathy-commits mailing list