[telepathy-gabble/telepathy-gabble-0.8] gabble_muc_channel_init: initialize self->priv correctly

Simon McVittie simon.mcvittie at collabora.co.uk
Thu Nov 12 06:42:06 PST 2009


It was uninitialized, which had never been significant so far because
all of muc-channel.c redundantly calls GABBLE_MUC_CHANNEL_GET_PRIVATE
again.
---
 src/muc-channel.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/muc-channel.c b/src/muc-channel.c
index 816fe41..cf6a110 100644
--- a/src/muc-channel.c
+++ b/src/muc-channel.c
@@ -279,7 +279,9 @@ initial_state_aggregator_free (InitialStateAggregator *isa)
 static void
 gabble_muc_channel_init (GabbleMucChannel *obj)
 {
-  GabbleMucChannelPrivate *priv = GABBLE_MUC_CHANNEL_GET_PRIVATE (obj);
+  GabbleMucChannelPrivate *priv;
+
+  priv = obj->priv = GABBLE_MUC_CHANNEL_GET_PRIVATE (obj);
 
   priv->initial_state_aggregator = g_slice_new0 (InitialStateAggregator);
   priv->initial_state_aggregator->owner_map = g_hash_table_new (g_direct_hash,
-- 
1.5.6.5




More information about the telepathy-commits mailing list