[telepathy-gabble/master] Remove unused vars from gabble_disco_service_find

Will Thompson will.thompson at collabora.co.uk
Fri Nov 13 10:07:10 PST 2009


Given that we don't use the key and value looked up from the features
hash, and you can just pass NULL to g_hash_table_lookup_extended(), this
makes the function more regular and easier to read.
---
 src/disco.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/disco.c b/src/disco.c
index f5f3347..db2e742 100644
--- a/src/disco.c
+++ b/src/disco.c
@@ -947,12 +947,9 @@ gabble_disco_service_find (GabbleDisco *disco,
       if (type != NULL && tp_strdiff (type, item->type))
         continue;
 
-      if (feature != NULL)
-        {
-          gpointer k, v;
-          if (!g_hash_table_lookup_extended (item->features, feature, &k, &v))
-            continue;
-        }
+      if (feature != NULL &&
+          !g_hash_table_lookup_extended (item->features, feature, NULL, NULL))
+        continue;
 
       return item;
     }
-- 
1.5.6.5




More information about the telepathy-commits mailing list