[telepathy-gabble/telepathy-gabble-0.8] Don't distribute config.py in source tarball

Will Thompson will.thompson at collabora.co.uk
Fri Nov 27 03:47:25 PST 2009


config.py is analogous to config.h: it's generated at build time based
on the arguments passed to configure. Having it in EXTRA_DIST led to the
interesting situation where `make distcheck` would:

• generate config.py while making the tarball, with DEBUGGING = True;
• generate it again when building, with DEBUGGING = False, but in
  _build/tests/twisted not in tests/twisted;
• fail the debugger test because python picked up the config.py from the
  source tree rather than from the build tree, leading to the test
  trying to use the debugger despite Gabble being built without it.

Reviewed-by: Simon McVittie <simon.mcvittie at collabora.co.uk>
---
 tests/twisted/Makefile.am |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tests/twisted/Makefile.am b/tests/twisted/Makefile.am
index 8386022..e50cdc1 100644
--- a/tests/twisted/Makefile.am
+++ b/tests/twisted/Makefile.am
@@ -193,7 +193,6 @@ BUILT_SOURCES = config.py
 EXTRA_DIST = \
 	$(TWISTED_TESTS) \
 	bytestream.py \
-	config.py \
 	constants.py \
 	gabbletest.py \
 	httptest.py \
-- 
1.5.6.5



More information about the telepathy-commits mailing list