[telepathy-mission-control/master] mcd_dispatcher_context_unref: remove the side-effect of forcibly finishing the dispatch operation

Simon McVittie simon.mcvittie at collabora.co.uk
Mon Oct 19 08:19:38 PDT 2009


This is no longer useful, since CTXREF15 is held at least until the
operation is finished, so this call is always a no-op.
---
 src/mcd-dispatcher.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/src/mcd-dispatcher.c b/src/mcd-dispatcher.c
index 3bf3994..8d2fb76 100644
--- a/src/mcd-dispatcher.c
+++ b/src/mcd-dispatcher.c
@@ -1902,13 +1902,6 @@ mcd_dispatcher_context_unref (McdDispatcherContext * context,
         g_signal_handlers_disconnect_by_func (context->operation,
             mcd_dispatcher_run_handlers, context);
 
-        /* may emit finished */
-        if (_mcd_dispatch_operation_finish (context->operation))
-        {
-            DEBUG ("Operation wasn't finished when context was unreffed down "
-                   "to nothing!");
-        }
-
         g_signal_handlers_disconnect_by_func (context->operation,
                                               on_operation_finished,
                                               context->dispatcher);
-- 
1.5.6.5




More information about the telepathy-commits mailing list