[telepathy-gabble/master] GabbleConnectionPrivate: explain what all the capabilities are, as per albanc's review

Simon McVittie simon.mcvittie at collabora.co.uk
Mon Sep 7 11:13:22 PDT 2009


---
 src/connection.c |   13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/connection.c b/src/connection.c
index 481e587..c98ddd9 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -200,12 +200,21 @@ struct _GabbleConnectionPrivate
   /* serial number of current advertised caps */
   guint caps_serial;
 
-  /* capabilities from various sources */
-  GabbleCapabilitySet *all_caps;
+  /* capabilities from various sources: */
+  /* subscriptions on behalf of the Connection, like PEP "+notify"
+   * namespaces (this one is add-only) */
   GabbleCapabilitySet *notify_caps;
+  /* caps provided by Capabilities.AdvertiseCapabilities (tp-spec 0.16) */
   GabbleCapabilitySet *legacy_caps;
+  /* additional caps that we advertise until the first call to
+   * AdvertiseCapabilities or UpdateCapabilities, for vague historical
+   * reasons */
   GabbleCapabilitySet *bonus_caps;
+  /* caps provided via ContactCapabilities.UpdateCapabilities ()
+   * gchar * (client name) => GabbleCapabilitySet * */
   GHashTable *client_caps;
+  /* the union of the above */
+  GabbleCapabilitySet *all_caps;
 
   /* gobject housekeeping */
   gboolean dispose_has_run;
-- 
1.5.6.5




More information about the telepathy-commits mailing list