[Telepathy] [Bug 17115] New: telepathy-glib uses pointers to pointers unnecessarily

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Aug 13 07:13:44 PDT 2008


http://bugs.freedesktop.org/show_bug.cgi?id=17115

           Summary: telepathy-glib uses pointers to pointers unnecessarily
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: telepathy-glib
        AssignedTo: telepathy at lists.freedesktop.org
        ReportedBy: murrayc at murrayc.com


telepath-glib seem to use Thing** when it really doesn't need to. This makes
the API awkward, by requiring extra dereferencing, needing extra checks for
NULL.

For instance, the TpConnectionManagerListCb callback provides a
TpConnectionManager** parameter instead of just a TpConnectionManager*.

http://telepathy.freedesktop.org/doc/telepathy-glib/telepathy-glib-connection-manager.html#TpConnectionManagerListCb

Also, for instance, TpConnectionManagerProtocol::protocols is a pointer to a
pointer, but a simple pointer would be just as good for a NULL-terminated array
of TpConnectionManagerProtocol:
http://telepathy.freedesktop.org/doc/telepathy-glib/telepathy-glib-connection-manager.html#TpConnectionManager-struct


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Telepathy mailing list