[Telepathy] [Bug 17115] telepathy-glib uses pointers to pointers unnecessarily

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=17115





--- Comment #4 from Murray Cumming <murrayc at murrayc.com>  2008-08-17 05:38:05 PST ---
(In reply to comment #2)
> At the time that TpConnectionManagerListCb was written, the size of a
> TpConnectionManager was not yet fixed, so we couldn't use a packed array of
> them. The (TpConnectionManager **) is effectively the contents of a GPtrArray
> of (TpConnectionManager *), with some attempt at type-safety.

I also don't see the sense of this. The size of a TpConnectionManager could
affect the size of a struct if it had an array of them as a member field, but
it's not going to affect the ABI when TpConnectionManager* is used as a
function (or callback) parameter. Either way, the application needs to know how
big the TpConnectionManager is. Requiring an extra dereference doesn't change
that.

And the struct implementations should be private, using the GObject priv
system, ideally, so there won't be a problem with base sizes changing.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.