[Telepathy] [Bug 19248] Patch that implement Connection.Interface.SimplePresence

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=19248





--- Comment #6 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2009-01-05 13:00:24 PST ---
Thanks for the updated patch. Just three tiny comments:

 * telepathy.server.DBusProperties.__init__(self)
   This is an unnecessary addition as telepathy.server.Connection calls this in
   its constructor. To be fair, this is a little harsh on you as I told you to
   post this patch before I released tp-python.

 * "(presence_type,presence,personal_message)" needs spaces

 * There are excessive newlines between the two classes in simple_presence.py.

It's just worth noting here for my benefit that this requires an updated dep of
tp-python to 0.15.4.

Thanks again for your patch.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.