[Telepathy] [PATCH] TelepathyQt4: Various bugs + patches to fix them

Simon McVittie simon.mcvittie at collabora.co.uk
Thu Jun 25 04:06:59 PDT 2009


On Thu, 25 Jun 2009 at 00:11:11 +0300, George Kiagiadakis wrote:
> I was about to report this bug now to mission-control, but then I
> noticed a detail in the spec:
> 
> In http://telepathy.freedesktop.org/spec.html#type-Qualified_Property_Value_Map
> it says:
> 
> Key - s (DBus_Qualified_Member)
>     A D-Bus interface name, followed by a dot and a D-Bus property name.
> 
> And notice that the Properties passed to this method
> (AddDispatchOperation) are of this type:
> 
> Properties - a{sv} (Qualified_Property_Value_Map)

Yes, MC is doing the right thing by emitting fully-qualified names. We can
only use unqualified names if the interface is implicit (i.e. almost never -
org.freedesktop.DBus.Properties.GetAll is the only example I can think of).

The idea of using the fully-qualified names is that an implementation of the
ChannelDispatcher that wanted to provide proprietary extra information could
provide more properties in an implementation-specific interface, so alongside
standard properties like
org.freedesktop.Telepathy.ChannelDispatchOperation.Account you could have
implementation-specific properties like
com.example.SuperDispatcher.CDO.ExtraFlag.

The fact that Connection and Account are mentioned in the spec in that form,
rather than with the full prefix that they have in the actual code, is perhaps
somewhat unclear, but I think there's a risk that quoting the literal strings
used would make the spec even less clear - they're quite long, and we don't
want the semantics of the spec to get lost in a maze of large literal
strings :-) I'd hoped that hyperlinking them would make it sufficiently clear,
but perhaps it isn't.

    Simon


More information about the telepathy mailing list