<div dir="ltr">Hi Andre<div>Thanks! This is the first time I'm submitting a patch to Telepathy Qt which is why i did not know the correct procedure. I'll keep this in mind when submitting my next set of patches.</div>
<div><br></div><div>Regards</div><div>Rohan Garg<br clear="all"><br><br><div class="gmail_quote">On Fri, Sep 30, 2011 at 6:20 AM, Andre Moreira Magalhaes <span dir="ltr"><<a href="mailto:andre.magalhaes@collabora.co.uk">andre.magalhaes@collabora.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hey Rohan,<br>
<div><div></div><div class="h5"><br>
On Thu, 2011-09-29 at 00:12 +0530, Rohan Garg wrote:<br>
<br>
> I was working on Telepathy KDE and i noticed that the '!=' operator<br>
> had not been implemented in Tp::Presence and Tp::PresenceSpec. This<br>
> patch fixes that. I know that one could easily use the '==' operator<br>
> and implement this functionality in the application using Tp::Presence<br>
> itself, but i think that this should be implemented by the<br>
> Tp::Presence class itself in order to keep code using the Telepathy<br>
> Qt4 API cleaner.<br>
</div></div>First thanks for the patch. The patch is fine and I will apply it to<br>
upstream master to be released in 0.7.3. As for future patches, I would<br>
like to ask you to please file a bug against Telepathy/tp-qt4 on<br>
<a href="http://bugs.freedesktop.org" target="_blank">bugs.freedesktop.org</a>, with the patch keyword, so it's easier to keep<br>
track and make review comments.<br>
<br>
BR,<br>
<font color="#888888">Andre<br>
<br>
<br>
</font></blockquote></div><br></div></div>