[waffle] [PATCH 7/7] nacl: add implementation for waffle_dl_sym

[Emil Velikov]

On 6 February 2015 at 19:44, Chad Versace <chad.versace at intel.com> wrote:
...
>
> The way that Waffle's Linux and Mac platforms work today, the user doesn't
> have to call waffle_dl_can_open(). When the user calls waffle_dl_sym(),
> Waffle internally calls dlopen() if the user hasn't called waffle_dl_sym()
> on that library before.
>
Thank you for the correction Chad.

I have to respectfully disagree for one bit - waffle_dl_sym does not
directly call waffle_dl_can_open. The former does trigger an
waffle_error as an invalid dl is selected, while the latter should
not*.

Currently Tapani directly executes nacl_dl_can_open within nacl_dl_sym
- thus no error is emitted for the latter. Imho he can resolve this by
following following cgl/linux example.

Cheers
Emil

[*] Upon closer look it seems that cgl does set a waffle_error on
waffle_dl_can_open. I will send out a patch later on today.