<div dir="ltr">On 28 December 2012 11:49, Chad Versace <span dir="ltr"><<a href="mailto:chad.versace@linux.intel.com" target="_blank">chad.versace@linux.intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">For each of the WAFFLE_*_SIZE attributes:<br>
  - change the default value from WAFFLE_DONT_CARE(-1) to 0, and<br>
  - change the valid range of values from [-1, +inf) to [0, +inf).<br>
<br>
This change aligns waffle's behavior to that of GLX [1], EGL [2], and (if<br>
I interpreted the CGL documentation correctly) CGL [3].<br>
<br>
This fixes a bug where, if the user didn't specify the value of a size<br>
attribute, then waffle passed WAFFLE_DONT_CARE(-1) to glXChooseFBConfig<br>
and eglChooseConfig. Per the GLX, EGL specs, -1 is an illegal value for<br>
size attributes.<br>
<br>
[1] GLX 1.4 spec (2005.12.16), Table 3.4<br>
[2] EGL 1.4 spec (2011.04.06), Table 3.4<br>
[3] <a href="https://developer.apple.com/library/mac/documentation/graphicsimaging/reference/CGL_OpenGL/Reference/reference.html#//apple_ref/c/func/CGLChoosePixelFormat" target="_blank">https://developer.apple.com/library/mac/documentation/graphicsimaging/reference/CGL_OpenGL/Reference/reference.html#//apple_ref/c/func/CGLChoosePixelFormat</a><br>

<br>
Reported-by: Brian Paul <<a href="mailto:brian.e.paul@gmail.com">brian.e.paul@gmail.com</a>><br>
Signed-off-by: Chad Versace <<a href="mailto:chad.versace@linux.intel.com">chad.versace@linux.intel.com</a>><br></blockquote><div><br></div><div>After this commit, I get the following errors from "make check":<br>
<br>test: failed tests:<br>  wcore_config_attrs.gl_defaults<br>  wcore_config_attrs.gles1_defaults<br>  wcore_config_attrs.gles2_defaults<br>  wcore_config_attrs.gles3_defaults<br>  wcore_config_attrs.color_buffer_size<br>
  wcore_config_attrs.double_buffered_is_true<br>  wcore_config_attrs.double_buffered_is_false<br><br><br></div><div>Paul</div></div></div></div>