<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 6, 2016 at 4:12 PM, Frank Henigman <span dir="ltr"><<a href="mailto:fjhenigman@google.com" target="_blank">fjhenigman@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Jan 6, 2016 at 6:43 PM, Dylan Baker <<a href="mailto:baker.dylan.c@gmail.com">baker.dylan.c@gmail.com</a>> wrote:<br>
> Okay, I have some comments:<br>
><br>
> When I run wflinfo -p gbm -a gl -f json | jsontidy (a small python script I<br>
> have that formats JSON to be human readable)<br>
> I get this:<br>
> {<br>
> "generic": {<br>
> "waffle": {<br>
> "api": "WAFFLE_CONTEXT_OPENGL",<br>
> "platform": "WAFFLE_PLATFORM_GBM"<br>
> },<br>
> "extensions": [<br>
> "GL_3DFX_texture_compression_FXT1",<br>
> ... (truncated for readability)<br>
> "GL_SUN_multi_draw_arrays"<br>
> ],<br>
> "opengl": {<br>
> "renderer": "Mesa DRI Intel(R) Haswell Mobile ",<br>
> "version": "3.0 Mesa 11.1.0",<br>
> "vendor": "Intel Open Source Technology Center"<br>
> },<br>
> "shading_language_version": "1.30"<br>
> }<br>
> }<br>
><br>
> I think the shading_language_version and extensions belong in the opengl<br>
> dictionary.<br>
<br>
</span>I didn't give much thought at the time to structure nor key names.<br>
Figured there<br>
would some debate in any case. (-:<br>
Makes sense to put gl extensions in the "opengl" block.<br>
How about a glsl block? Seems like there might be other stuff in it some day,<br>
and adds consistency to the use of "version" i.e.<br>
"glsl" : {<br>
"version" : "1.30"<br>
}<br>
I'm not as sure about putting it inside the opengl block, but not<br>
fussy about it either.<br>
If there's no dissent I'll do as you suggest.<br></blockquote><div><br></div><div>Putting it an a "glsl" block sounds better to me.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
> Other than that the output seems reasonable and quite usable for my<br>
> purposes.<br>
<br>
</span>Once again sorry for not sending mine out sooner. If none of your patch makes<br>
it in, hopefully it had some value to you as an exercise.<br></blockquote><div><br></div><div>It did have that. <br></div></div><br></div></div>