<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [bug] Weston tooltips are incorrectly cropped" href="https://bugs.freedesktop.org/show_bug.cgi?id=52454#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [bug] Weston tooltips are incorrectly cropped" href="https://bugs.freedesktop.org/show_bug.cgi?id=52454">bug 52454</a> from <a class="email" href="mailto:krh@bitplanet.net" title="Kristian Høgsberg <krh@bitplanet.net>"> Kristian Høgsberg</a> <pre>(In reply to <a href="show_bug.cgi?id=52454#c4">comment #4</a>) > Created <a href="attachment.cgi?id=69268" name="attach_69268" title="patch">attachment 69268</a> <a href="attachment.cgi?id=69268&action=edit" title="patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=52454&attachment=69268'>[review]</a> [review] > patch > > (In reply to <a href="show_bug.cgi?id=52454#c3">comment #3</a>) > > I'm still able to reproduce this issue using cairo-image on today's master > > bits (I have not tried with cairo-egl). > > I was able to reproduce this with --with-cairo-glesv2 and decided to look > into it. The problem is that window->cairo_surface is NULL when > get_text_extents() is called because this surface is destroyed on attach, > for the shm path. I've attached a patch to fix the problem. I'm not sure if > it's correct since I'm not sure why cairo_surface is destroyed on the shm > path only. Yeah, I think this is a good fix. I thought we relies on the surface being destroyed after flush, but that's obviously not how the EGL surface works. Your patch brings the two backends closer in how they work and fix the problem... let's go with that. Mind sending it to the list?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>