<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [bug] Black screen running Weston master with mesa master"
href="https://bugs.freedesktop.org/show_bug.cgi?id=67541#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [bug] Black screen running Weston master with mesa master"
href="https://bugs.freedesktop.org/show_bug.cgi?id=67541">bug 67541</a>
from <span class="vcard"><a class="email" href="mailto:ppaalanen@gmail.com" title="Pekka Paalanen <ppaalanen@gmail.com>"> <span class="fn">Pekka Paalanen</span></a>
</span></b>
<pre>I see what happened.
Weston's GL renderer used to have an #ifdef GL_UNPACK_ROW_LENGTH check to check
the availability of the GL_EXT_unpack_subimage extension in the GLES2 headers.
The said Mesa commit renamed GL_UNPACK_ROW_LENGTH to GL_UNPACK_ROW_LENGTH_EXT.
That caused the Weston build to think that GL_EXT_unpack_subimage is not
available at build time, so it never compiled that code at all. However, the
runtime check for GL_EXT_unpack_subimage in the GL extension string was not
protected with an #ifdef, and when Weston ran, it found the extension.
The end result is, that gl_renderer_flush_damage() did not do a plain
glTexImage2D because GL_EXT_unpack_subimage was available, and it did not try
glTexSubImage2D either because the code was not compiled. So it never uploaded
the texture.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>