<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:krh@bitplanet.net" title="Kristian Høgsberg <krh@bitplanet.net>"> <span class="fn">Kristian Høgsberg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - SIGSEGV in shell_surface_move"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68649">bug 68649</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - SIGSEGV in shell_surface_move"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68649#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - SIGSEGV in shell_surface_move"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68649">bug 68649</a>
from <span class="vcard"><a class="email" href="mailto:krh@bitplanet.net" title="Kristian Høgsberg <krh@bitplanet.net>"> <span class="fn">Kristian Høgsberg</span></a>
</span></b>
<pre>...
<span class="quote">> The troublesome code is in shell.c/shell_surface_move -- seat->touch is NULL
> which
> clearly causes a SEGV:
> } else if (seat->touch->grab_serial == serial) {
>
> I don't have any touch devices. Should there be some extra check here?</span >
There should indeed, thanks. Committed to weston master (and will be in
1.2.2):
commit e1b655df922d1feb2409a1401c83041747645175
Author: Kristian Høgsberg <<a href="mailto:krh@bitplanet.net">krh@bitplanet.net</a>>
Date: Wed Aug 28 23:16:20 2013 -0700
shell: Make sure we have seat->pointer and seat->touch before dereferencing
Either of these may not be available when we handle wl_shell_surface.move,
and we need to not crash when that's the case.
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - SIGSEGV in shell_surface_move"
href="show_bug.cgi?id=68649">https://bugs.freedesktop.org/show_bug.cgi?id=68649</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>