<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:krh@bitplanet.net" title="Kristian Høgsberg <krh@bitplanet.net>"> <span class="fn">Kristian Høgsberg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - SIGSEGV in Weston run_touch_binding"
href="https://bugs.freedesktop.org/show_bug.cgi?id=72839">bug 72839</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - SIGSEGV in Weston run_touch_binding"
href="https://bugs.freedesktop.org/show_bug.cgi?id=72839#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - SIGSEGV in Weston run_touch_binding"
href="https://bugs.freedesktop.org/show_bug.cgi?id=72839">bug 72839</a>
from <span class="vcard"><a class="email" href="mailto:krh@bitplanet.net" title="Kristian Høgsberg <krh@bitplanet.net>"> <span class="fn">Kristian Høgsberg</span></a>
</span></b>
<pre>Those touch coordinates in the backtrace look really out of place, that may be
a different problem in itself. But there are a few corner cases where we can
legitimately fail to touch a surface, so we need to check for NULL in
touch_to_activate_binding().
commit 0ed6750541eac94af7083fabe5911c20e6ca31f9
Author: Kristian Høgsberg <<a href="mailto:krh@bitplanet.net">krh@bitplanet.net</a>>
Date: Thu Jan 2 23:00:11 2014 -0800
shell: Only assign focus on touch if there is a touch focus surface
Similar to 7c4f6cc145daf66cd9624f1e70dd5278241f5858, if we don't have
a background image from the desktop-shell client or the touch point
for some other reason doesn't hit a surface we trigger a
segfault as we try to deref the seat->touch->focus NULL pointer.
For touch, another problem could be fudgey calibration that ends up
giving touch coordinates outside the output space.
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - SIGSEGV in Weston run_touch_binding"
href="show_bug.cgi?id=72839">https://bugs.freedesktop.org/show_bug.cgi?id=72839</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>