<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ppaalanen@gmail.com" title="Pekka Paalanen <ppaalanen@gmail.com>"> <span class="fn">Pekka Paalanen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - wl_shm_pool_resize crashes weston"
href="https://bugs.freedesktop.org/show_bug.cgi?id=74632">bug 74632</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Component</td>
<td>weston
</td>
<td>wayland
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - wl_shm_pool_resize crashes weston"
href="https://bugs.freedesktop.org/show_bug.cgi?id=74632#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - wl_shm_pool_resize crashes weston"
href="https://bugs.freedesktop.org/show_bug.cgi?id=74632">bug 74632</a>
from <span class="vcard"><a class="email" href="mailto:ppaalanen@gmail.com" title="Pekka Paalanen <ppaalanen@gmail.com>"> <span class="fn">Pekka Paalanen</span></a>
</span></b>
<pre>Yikes. Yes, the client behavior you describe is an application bug, in that it
is reusing/destroying the buffer's storage without waiting for a
wl_buffer.release, right? Also the client should destroy the wl_buffer before
invalidating its storage.
But this client bug also exposes a weston bug in that weston really should not
crash here.
Actually this needs to be fixed in libwayland-server, because the
wl_shm_pool_resize is handled there. I'd prefer to send a fatal error to the
client immediately when a resize attempts invalidate the storage of any
existing wl_buffer, rather than check on use. We may also want to add a note of
this in the protocol spec.
A simpler alternative would be to specify that resize must never make the size
smaller. I am unsure which one would be preferable.
Therefore I am changing the component to "wayland", on a quick glance I do not
see anything needing fixing in Weston code.
Thanks for reporting this.
(I'm only analyzing this one for now, not assigning it to myself.)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>