<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Wayland clients can be affected by GL_MAX_TEXTURE_SIZE"
href="https://bugs.freedesktop.org/show_bug.cgi?id=75390#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Wayland clients can be affected by GL_MAX_TEXTURE_SIZE"
href="https://bugs.freedesktop.org/show_bug.cgi?id=75390">bug 75390</a>
from <span class="vcard"><a class="email" href="mailto:ppaalanen@gmail.com" title="Pekka Paalanen <ppaalanen@gmail.com>"> <span class="fn">Pekka Paalanen</span></a>
</span></b>
<pre>My opinion on the matter is still the same as in the email quoting an irc
conversation:
- for wl_shm, clients do not need to care, and compositors need to be prepared
to deal with huge sizes
- for EGL Wayland platform, rendering such a big size will probably fail
anyway, or it should be made to fail if the compositor cannot texture from the
render target.
Any crashing or hanging is of course a bug and needs to be fixed. These should
be separate bug reports.
I guess the problematic case you are hitting is a software rendered client on a
Weston with gl-renderer, right? I'm slightly surprised the hw can do GLESv2 to
begin with, but maybe you have a huge desktop over multiple monitors?
I'm not totally sure it must be fixed, but if anyone cares, it would be a
change limited inside the gl-renderer, and hence be fairly self-contained work.
No protocol work would be involved. A proper fix would be to split the surface
into several GL textures. A hack to prevent the window becoming invisible and
hence almost unrecoverable would be to just clamp the GL texture size to what
the hw can support, ignore the rest of the wl_shm buffer, and use something
like GL_CLAMP_TO_EGDE for rendering the surface so it is obvious something is
going wrong without misplacing the surface parts that can be rendered fine.
A stupid suggestion for users: use Weston's pixman renderer, it should not have
size restrictions.
Having clients tile themselves is likely not worth it, IMO. Using wl_shm is
already a fallback that should work, and clients could refuse to resize to
larger than what the GL stack supports. I guess this would be another reason to
have wl_egl_* size API to be able to report errors on invalid sizes before
rendering.
If clients really do want to tile, they can do so with sub-surfaces.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>