<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - wl_display_roundtrip() seems not thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=83304#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - wl_display_roundtrip() seems not thread-safe"
href="https://bugs.freedesktop.org/show_bug.cgi?id=83304">bug 83304</a>
from <span class="vcard"><a class="email" href="mailto:ppaalanen@gmail.com" title="Pekka Paalanen <ppaalanen@gmail.com>"> <span class="fn">Pekka Paalanen</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=83304#c3">comment #3</a>)
<span class="quote">> Pekka, the mainloop is simplistic and tries to follow the documentation:
> <a href="https://git.videolan.org/?p=vlc.git;a=blob;f=modules/video_output/wl/">https://git.videolan.org/?p=vlc.git;a=blob;f=modules/video_output/wl/</a>
> shell_surface.c;hb=2.2.0-git-662-ge08f4fc#l48</span >
That looks fine.
<span class="quote">> (Admittedly the cleanup path may look unorthodox, but you can ignore it as
> the deadlock predates it.) The deadlock is there, right below FIXME:
>
> <a href="https://git.videolan.org/?p=vlc.git;a=blob;f=modules/video_output/wl/shm.c">https://git.videolan.org/?p=vlc.git;a=blob;f=modules/video_output/wl/shm.c</a>;
> hb=2.2.0-git-662-ge08f4fc#l184</span >
That is broken like I explained above, it runs in a different thread, doesn't
it?
<span class="quote">> I tried to use wl_event_queue, but it gave me crashes in the mainloop after
> destroying the supposedly no longer used queue. I guess I don't know
> how/when it is safe to delete a queue.</span >
Can you show the code for that? There likely are several details to get right,
like assigning proxies to queues, and when to create and destroy queues.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>