<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - implement minimize / maximize functionality" href="https://bugzilla.gnome.org/show_bug.cgi?id=695945#c19">Comment # 19</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - implement minimize / maximize functionality" href="https://bugzilla.gnome.org/show_bug.cgi?id=695945">bug 695945</a> from <a href="page.cgi?id=describeuser.html&login=krejzi%40email.com" title="Armin K. <krejzi@email.com>"> Armin K.</a> <pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=695945#c18">comment #18</a>) > Review of <a href="attachment.cgi?id=296287&action=diff" name="attach_296287" title="Implement Minimize in GDK Wayland backend">attachment 296287</a> <a href="attachment.cgi?id=296287&action=edit" title="Implement Minimize in GDK Wayland backend">[details]</a> <a href='/review?bug=695945&attachment=296287'>[review]</a> [review]: > > ::: gdk/wayland/gdkwindow-wayland.c > @@ +1693,3 @@ > + > + if (GDK_WINDOW_IS_MAPPED (window)) > + xdg_surface_set_minimized (impl->xdg_surface); > > We don't have the mapped check in any other window state setters in this > file. If it is needed, that should be a separate bug-fix (for all the > setters). But I don't think it is needed because the xdg_surface is created > as part of mapping the window. I suppose I copy/pasted the check from the deiconify handler. It should be trivial to fix.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>