<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - implement minimize / maximize functionality"
href="https://bugzilla.gnome.org/show_bug.cgi?id=695945">bug 695945</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #296287 status</td>
<td>none
</td>
<td>needs-work
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - implement minimize / maximize functionality"
href="https://bugzilla.gnome.org/show_bug.cgi?id=695945#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - implement minimize / maximize functionality"
href="https://bugzilla.gnome.org/show_bug.cgi?id=695945">bug 695945</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=296287&action=diff" name="attach_296287" title="Implement Minimize in GDK Wayland backend">attachment 296287</a> <a href="attachment.cgi?id=296287&action=edit" title="Implement Minimize in GDK Wayland backend">[details]</a></span> <a href='/review?bug=695945&attachment=296287'>[review]</a>:
::: gdk/wayland/gdkwindow-wayland.c
@@ +1693,3 @@
+
+ if (GDK_WINDOW_IS_MAPPED (window))
+ xdg_surface_set_minimized (impl->xdg_surface);
We don't have the mapped check in any other window state setters in this file.
If it is needed, that should be a separate bug-fix (for all the setters). But I
don't think it is needed because the xdg_surface is created as part of mapping
the window.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>