<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: do not use g_error() on connection errors"
href="https://bugzilla.gnome.org/show_bug.cgi?id=745289">bug 745289</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #298092 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: do not use g_error() on connection errors"
href="https://bugzilla.gnome.org/show_bug.cgi?id=745289#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: do not use g_error() on connection errors"
href="https://bugzilla.gnome.org/show_bug.cgi?id=745289">bug 745289</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=298092&action=diff" name="attach_298092" title="Patch to fix the issue.">attachment 298092</a> <a href="attachment.cgi?id=298092&action=edit" title="Patch to fix the issue.">[details]</a></span> <a href='/review?bug=745289&attachment=298092'>[review]</a>:
::: gdk/wayland/gdkeventsource.c
@@ +162,3 @@
{
+ if (wl_display_dispatch (display_wayland->wl_display) < 0) {
+ g_printerr ("Error dispatching display: %s\n", g_strerror (errno));
As mentioned on irc: Probably better to say "Wayland display" here.
@@ +168,3 @@
+ if (source->pfd.revents & (G_IO_ERR | G_IO_HUP)) {
+ g_printerr ("Lost connection to wayland compositor\n");
And "Wayland compositor" here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>