<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - wayland: Support HiDPI pointer cursors" href="https://bugzilla.gnome.org/show_bug.cgi?id=746141#c15">Comment # 15</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - wayland: Support HiDPI pointer cursors" href="https://bugzilla.gnome.org/show_bug.cgi?id=746141">bug 746141</a> from <a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> Jonas Ådahl</a> <pre>(In reply to Jonas Ådahl from <a href="show_bug.cgi?id=746141#c12">comment #12</a>) > Created <a href="attachment.cgi?id=299481&action=diff" name="attach_299481" title="wayland: Don't set cursor surface scale when we don't have a surface">attachment 299481</a> <a href="attachment.cgi?id=299481&action=edit" title="wayland: Don't set cursor surface scale when we don't have a surface">[details]</a> <a href='review?bug=746141&attachment=299481'>[review]</a> [review] > wayland: Don't set cursor surface scale when we don't have a surface > > The setting of the the surface scale even when the surface is not > created from a surface was introduced due to a crash when getting the > buffers when dividing by the scale. The only reason I can see this is > that we get the buffer from a non-existing surface when the wl_cursor > has not yet been set. > > Instead, use the name field to avoid trying to use the non-existing > surface, effectively avoiding the division-by-zero that way. The original version had missing fallback NULL return. The new version fixes that.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>