<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>(In reply to Owen Taylor from <a href="show_bug.cgi?id=744932#c21">comment #21</a>)
<span class="quote">> Review of <span class=""><a href="attachment.cgi?id=299278&action=diff" name="attach_299278" title="Make MetaCursorSprite a GObject">attachment 299278</a> <a href="attachment.cgi?id=299278&action=edit" title="Make MetaCursorSprite a GObject">[details]</a></span> <a href='review?bug=744932&attachment=299278'>[review]</a> [review]:
>
> ::: src/backends/meta-cursor-tracker.c
> @@ +90,3 @@
> + {
> + g_object_ref (displayed_cursor);
> + tracker->displayed_cursor = displayed_cursor;
>
> g_object_returns the ref'ed object as well - not sure if this change is
> because you aren't aware of that or object to that stylistically.</span >
Is it a stylistic guideline to do o = g_object_ref (o)? I was aware of it
returning the object, but assumed relying on the side effect was enough. If the
guideline is to do o = g_object_ref (o) I can change it.
<span class="quote">>
> ::: src/backends/meta-cursor.c
> @@ +54,3 @@
> +} MetaCursorImage;
> +
> +struct _MetaCursorSpritePrivate
>
> This is OK, but to express my opinion, I don't really see any reason to use
> a private structure - private structures are basically useful for publicly
> derivable objects where you need to have the object class in a public
> header. MetaCursorSprite isn't derivable and it isn't even public.</span >
The point of making it private is to not tempt anyone to use
cursor_sprite->internal_data and instead use a provided API. I think this makes
sense even if the object is not exposed publicly.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>