<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932#c31">Comment # 31</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=otaylor%40redhat.com" title="Owen Taylor <otaylor@redhat.com>"> <span class="fn">Owen Taylor</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=301060&action=diff" name="attach_301060" title="wayland: Paint proper pointer cursor size on HiDPI monitors">attachment 301060</a> <a href="attachment.cgi?id=301060&action=edit" title="wayland: Paint proper pointer cursor size on HiDPI monitors">[details]</a></span> <a href='review?bug=744932&attachment=301060'>[review]</a>:
Hmm, this deviates a lot from how I'd expect things to be organized. Use your
judgement whether you agree with me or not :-) If you want me to review things
as is without any reconceptualization of MetaCursorSprite , let me know, and
I'll do that.
::: src/backends/meta-cursor-renderer.c
@@ -103,3 @@
- priv->current_rect.y = priv->current_y - hot_y;
- priv->current_rect.width = cogl_texture_get_width (COGL_TEXTURE
(texture));
- priv->current_rect.height = cogl_texture_get_height (COGL_TEXTURE
(texture));
I'd have expected the rectangle computations to stay here and the
MetaCursorSprite operation to be more like "here's the desired scale, what do
you have for me?"
::: src/frontends/wayland/meta-cursor-wayland.c
@@ +129,3 @@
+ image_scale = 1;
+ if (priv->monitor_scale != monitor->scale)
+ meta_cursor_sprite_load_from_theme (cursor_sprite, monitor->scale);
This is certainly not where I'd expect to find this code... in the pure
"frontend" conceptualization of MetaCursorSprite, a MetaCursorSpriteWayland has
nothing to do with themed cursors - a wayland cursor is one set by a Wayland
client.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>