<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - Double tap not always recognized" href="https://bugs.freedesktop.org/show_bug.cgi?id=90172#c19">Comment # 19</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - Double tap not always recognized" href="https://bugs.freedesktop.org/show_bug.cgi?id=90172">bug 90172</a> from <a class="email" href="mailto:peter.hutterer@who-t.net" title="Peter Hutterer <peter.hutterer@who-t.net>"> Peter Hutterer</a> <pre>Not a bad idea re:tap to end drag timeout and increasing that timeout in general, please file that as separate bugs though, it's too hard to keep track of everything otherwise. (In reply to Velimir Lisec from <a href="show_bug.cgi?id=90172#c15">comment #15</a>) > (In reply to Peter Hutterer from <a href="show_bug.cgi?id=90172#c14">comment #14</a>) > > I don't think we can actually reduce the first tap timeout by much. If you > > hit a ~200ms delay on a "normal tap" (<a href="show_bug.cgi?id=90172#c9">comment #9</a>) then reducing it further > > risks missing it altogether. > > Yes, but if I'm not mistaken in the current implementation timer is reset > after the first release event arrives. That means that delay between first > touch down event and first release event is DEFAULT_TAP_TIMEOUT_PERIOD, and > delay between first release event and second touch event is also > DEFAULT_TAP_TIMEOUT_PERIOD. 200 ms from "normal tap" is delay between first > and second touch down event. So with current implementation, if > DEFAULT_TAP_TIMEOUT_PERIOD is set at 180, delay between first and second > touch down events can theoretically go up to 360 ms (180 + 180) and the tap > would still be recognized. true but that assumes no delay whatsoever. depending on what the system is up to, there can be a delay between the timer triggering and us actually processing the event. Which is, I think, the reason you had a 200ms delay in one of your recordings. And note that you labelled that recording as "normal speed", shortening the timeout would've missed the first tap. So for double-tap I think a longer + slightly shorter combination may be better. > I get the best results with the first patch applied and > DEFAULT_TAP_TIMEOUT_PERIOD set to 150 ms so I think you should use that one. again, don't forget that you thought normal speed was 200ms. and don't underestimate the training effect, it's what makes things like this really really hard to test. you pretty much need to stop after 2-3 tests and come back a few hours later (yes, it's as annoying as it sounds, tell me about it :)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>