<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - warnings when starting drag from GtkEntries"
href="https://bugzilla.gnome.org/show_bug.cgi?id=748763">bug 748763</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #302730 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - warnings when starting drag from GtkEntries"
href="https://bugzilla.gnome.org/show_bug.cgi?id=748763#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - warnings when starting drag from GtkEntries"
href="https://bugzilla.gnome.org/show_bug.cgi?id=748763">bug 748763</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=302730&action=diff" name="attach_302730" title="window: Avoid destroying the hardcoded window">attachment 302730</a> <a href="attachment.cgi?id=302730&action=edit" title="window: Avoid destroying the hardcoded window">[details]</a></span> <a href='review?bug=748763&attachment=302730'>[review]</a>:
::: gtk/gtkwindow.c
@@ +7333,3 @@
+ gtk_container_forall (GTK_CONTAINER (widget),
+ (GtkCallback) gtk_widget_unrealize,
+ NULL);
Hmm, this seems to manually do what the parent_class unrealize would do anyway
?
It would be nicer if we could still unconditionally chain up - just clear out
the hardcoded_window first ?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>