<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Wayland backend depends on ordering of globals in the display server" href="https://bugzilla.gnome.org/show_bug.cgi?id=719819#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Wayland backend depends on ordering of globals in the display server" href="https://bugzilla.gnome.org/show_bug.cgi?id=719819">bug 719819</a> from <a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> Jonas Ådahl</a> <pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=719819#c5">comment #5</a>) > Review of <a href="attachment.cgi?id=303510&action=diff" name="attach_303510" title="wayland: Add global object depedency tracking">attachment 303510</a> <a href="attachment.cgi?id=303510&action=edit" title="wayland: Add global object depedency tracking">[details]</a> <a href='review?bug=719819&attachment=303510'>[review]</a> [review]: > > ::: gdk/wayland/gdkdisplay-wayland.c > @@ +366,3 @@ > + if (handled) > + g_hash_table_insert (display_wayland->known_globals, > + GUINT_TO_POINTER (id), g_strdup (interface)); > > Given that the one use for this hash table is to look up globals by their > interface, wouldn't it make more sense to flip this around, and make the > interface name the key ? Then you can actually use the hash table as it was > meant to be used: by doing lookups, instead of iterating over it... There may be more than one global per interface name (multiple seats, multiple outputs), so we wouldn't know how to delete if we didn't use the id as key. We could, I suppose, change it to ignore that globals may be removed, since we only use this during initialization anyway.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>