<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Wayland backend depends on ordering of globals in the display server"
href="https://bugzilla.gnome.org/show_bug.cgi?id=719819">bug 719819</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>mclasen@redhat.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wayland backend depends on ordering of globals in the display server"
href="https://bugzilla.gnome.org/show_bug.cgi?id=719819#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wayland backend depends on ordering of globals in the display server"
href="https://bugzilla.gnome.org/show_bug.cgi?id=719819">bug 719819</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>(In reply to Jonas Ådahl from <a href="show_bug.cgi?id=719819#c6">comment #6</a>)
<span class="quote">> (In reply to Matthias Clasen from <a href="show_bug.cgi?id=719819#c5">comment #5</a>)
> > Review of <span class=""><a href="attachment.cgi?id=303510&action=diff" name="attach_303510" title="wayland: Add global object depedency tracking">attachment 303510</a> <a href="attachment.cgi?id=303510&action=edit" title="wayland: Add global object depedency tracking">[details]</a></span> <a href='review?bug=719819&attachment=303510'>[review]</a> [review] [review]:
> >
> > ::: gdk/wayland/gdkdisplay-wayland.c
> > @@ +366,3 @@
> > + if (handled)
> > + g_hash_table_insert (display_wayland->known_globals,
> > + GUINT_TO_POINTER (id), g_strdup (interface));
> >
> > Given that the one use for this hash table is to look up globals by their
> > interface, wouldn't it make more sense to flip this around, and make the
> > interface name the key ? Then you can actually use the hash table as it was
> > meant to be used: by doing lookups, instead of iterating over it...
>
> There may be more than one global per interface name (multiple seats,
> multiple outputs), so we wouldn't know how to delete if we didn't use the id
> as key. We could, I suppose, change it to ignore that globals may be
> removed, since we only use this during initialization anyway.</span >
I see, so it is really just a list of globals. I guess we could store it as a
plain list of struct { global; interface} or make the interface name the key
and store a list of globals. But given that the list of globals is small and
essentially fixed, we could also just leave it as it is.
A comment would be useful, though</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>