<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - File descriptor leak in gdk_wayland_selection_request_target()" href="https://bugzilla.gnome.org/show_bug.cgi?id=751414#c19">Comment # 19</a> on <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - File descriptor leak in gdk_wayland_selection_request_target()" href="https://bugzilla.gnome.org/show_bug.cgi?id=751414">bug 751414</a> from <a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> Carlos Garnacho</a> <pre>Created <a href="attachment.cgi?id=306050&action=diff" name="attach_306050" title="wayland: protect against unknown mimetype requests">attachment 306050</a> <a href="attachment.cgi?id=306050&action=edit" title="wayland: protect against unknown mimetype requests">[details]</a> <a href='review?bug=751414&attachment=306050'>[review]</a> wayland: protect against unknown mimetype requests This oddly can be reproduced with weston+weston-dnd, when dragging anything from GTK+ into weston-dnd, it will insist on picking its custom application/x-wayland-dnd-flower mimetype, and this request forwarded by the compositor, even if GTK+ didn't announce it on its wl_data_source mimetype list. (What should probably happen here is that the request is silenced, and/or weston-dnd picks (null)) This should be harmless, we are leaking though the fd in that case, because the emission of GdkEventSelection on an unhandled mimetype results in NOP. In order to avoid this, we should check whether the mimetype is supported at all on the backend code and possibly close the fd, this involves storing these in the first place.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>