<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - File descriptor leak in gdk_wayland_selection_request_target()" href="https://bugzilla.gnome.org/show_bug.cgi?id=751414#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - File descriptor leak in gdk_wayland_selection_request_target()" href="https://bugzilla.gnome.org/show_bug.cgi?id=751414">bug 751414</a> from <a href="page.cgi?id=describeuser.html&login=mcatanzaro%40gnome.org" title="Michael Catanzaro <mcatanzaro@gnome.org>"> Michael Catanzaro</a> <pre>Unfortunately your patch is wrong too; in my tests, GTK+ with your patch (which went into master this morning) leaks roughly half as many fds as it did previously, whereas my patch plugs the leak completely. (But don't apply my patch, it probably breaks things worse, I need to study this more still. :) We should not close() the fd manually because we pass TRUE as the second argument to g_unix_output_stream_new(). So actually, this may not be a leak per se, but a protocol flaw. Perhaps GTK+ will eventually free the fds if the other client ever reads the data from the pipe (which my attacking client does not ever do).</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>