<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - wayland: Always apply scaling factor to cursor hotspot and dimension" href="https://bugzilla.gnome.org/show_bug.cgi?id=752616#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - wayland: Always apply scaling factor to cursor hotspot and dimension" href="https://bugzilla.gnome.org/show_bug.cgi?id=752616">bug 752616</a> from <a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> Jonas Ådahl</a> <pre>(In reply to Carlos Garnacho from <a href="show_bug.cgi?id=752616#c2">comment #2</a>) > Review of <a href="attachment.cgi?id=307735&action=diff" name="attach_307735" title="wayland: Always apply scaling factor to cursor hotspot and dimension">attachment 307735</a> <a href="attachment.cgi?id=307735&action=edit" title="wayland: Always apply scaling factor to cursor hotspot and dimension">[details]</a> <a href='review?bug=752616&attachment=307735'>[review]</a> [review]: > > LGTM. /me wonders if it's really needed to store scale separately for > surface/non-surface cases after reading code around. Reason is mostly to have a logical separation between the "surface based" cursor state, and a "wl_cursor" based cursor state. Only one is valid at any time, so a "scale" parameter could be shared, but it'd mix the what parts is valid at what time separation.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>