<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen" href="https://bugzilla.gnome.org/show_bug.cgi?id=744932#c68">Comment # 68</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen" href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a> from <a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> Jonas Ådahl</a> <pre>(In reply to Jasper St. Pierre from <a href="show_bug.cgi?id=744932#c62">comment #62</a>) > Review of <a href="attachment.cgi?id=307718&action=diff" name="attach_307718" title="Move meta-cursor* from backends/ to core/">attachment 307718</a> <a href="attachment.cgi?id=307718&action=edit" title="Move meta-cursor* from backends/ to core/">[details]</a> <a href='review?bug=744932&attachment=307718'>[review]</a> [review]: > > Nah. core/ is for core window management logic. Just leave it in backends/, > please. Well its not part of the backend either, but fine. (In reply to Jasper St. Pierre from <a href="show_bug.cgi?id=744932#c64">comment #64</a>) > Review of <a href="attachment.cgi?id=307715&action=diff" name="attach_307715" title="MetaCursorSprite: Put renderer specific code in the renderer">attachment 307715</a> <a href="attachment.cgi?id=307715&action=edit" title="MetaCursorSprite: Put renderer specific code in the renderer">[details]</a> <a href='review?bug=744932&attachment=307715'>[review]</a> [review]: > > Actually, it says "this causes the X11 case to always generate the texture, > will be fixed in a following commit", but I don't see any place where you > actually fix this... It happens in the huge (second last) patch. The texture is loaded from "meta_cursor_sprite_realize_texture() which is called by the renderer when it knows it needs it. (In reply to Jasper St. Pierre from <a href="show_bug.cgi?id=744932#c61">comment #61</a>) > Review of <a href="attachment.cgi?id=307717&action=diff" name="attach_307717" title="wayland: GObject:ify surface roles">attachment 307717</a> <a href="attachment.cgi?id=307717&action=edit" title="wayland: GObject:ify surface roles">[details]</a> <a href='review?bug=744932&attachment=307717'>[review]</a> [review]: > > Not at all a fan of this. Instead of a GObject, perhaps just use a regular > struct of vfuncs? In the second last patch I put state in the cursor role object and I also g_signal_connect_object it. The signal I suppose can be connected to the surface object, but then I'd still have to have a data type that has instance variables, vfuncs and a destroy vfunc, which means I'd end up with special purpose GObject-mini type. Just using GObject felt more reasonable because of that. I have also had ideas about moving out all the window logic from MetaWaylandSurface to a window role or similar, and then it might be nice to actually be a GObject. (In reply to Jasper St. Pierre from <a href="show_bug.cgi?id=744932#c57">comment #57</a>) > Review of <a href="attachment.cgi?id=307719&action=diff" name="attach_307719" title="backends/x11: Draw our own cursor sprite when running nested">attachment 307719</a> <a href="attachment.cgi?id=307719&action=edit" title="backends/x11: Draw our own cursor sprite when running nested">[details]</a> <a href='review?bug=744932&attachment=307719'>[review]</a> [review]: > > Considering I originally wrote the X11 cursor renderer with the goal of > nested in mind, I'm not exactly sure what the point is here. With cursors having different themes depending on what (nested) output it is on, it felt more close to reality to just always draw it as a texture instead of hiding and showing the server cursor. It felt cleaner to just have a separate renderer for the nested case since it'd share none of the functionality.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>