<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Dual Monitors Issue. Weston gives both the same name." href="https://bugs.freedesktop.org/show_bug.cgi?id=89361#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Dual Monitors Issue. Weston gives both the same name." href="https://bugs.freedesktop.org/show_bug.cgi?id=89361">bug 89361</a> from <a class="email" href="mailto:ppaalanen@gmail.com" title="Pekka Paalanen <ppaalanen@gmail.com>"> Pekka Paalanen</a> <pre>Patches should be sent to mailing list with 'git send-email'. However, the proposed patch does not use any familiar names. It seems compositor-drm.c's output naming could probably use even more fixing, looking at drmmode_create_name() in <a href="http://cgit.freedesktop.org/xorg/xserver/tree/hw/xfree86/drivers/modesetting/drmmode_display.c#n1358">http://cgit.freedesktop.org/xorg/xserver/tree/hw/xfree86/drivers/modesetting/drmmode_display.c#n1358</a> . OTOH, I suppose we should leave MST support for another time, and just fix the current stuff. Comparing our name table in compositor-drm.c to that of -modesetting's, it seems it should have the same issue, Weston is missing a couple of entries, and not just DVI but also TV and HDMI entries might theoretically produce duplicates. Weston is also using slightly different names on some. Makes me wonder what convention we should follow. The actual meanings I think are authoritatively defined here with the DRM_MODE_CONNECTOR_*: <a href="http://cgit.freedesktop.org/mesa/drm/tree/include/drm/drm_mode.h#n201">http://cgit.freedesktop.org/mesa/drm/tree/include/drm/drm_mode.h#n201</a> The name tables just follow that exact ordering. Have you tried if Xorg with -modesetting driver has the same identical name issue? If they have, you might want to file a bug for that too.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>