<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=otaylor%40redhat.com" title="Owen Taylor <otaylor@redhat.com>"> <span class="fn">Owen Taylor</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #309532 status</td>
<td>none
</td>
<td>needs-work
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932#c96">Comment # 96</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=otaylor%40redhat.com" title="Owen Taylor <otaylor@redhat.com>"> <span class="fn">Owen Taylor</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=309532&action=diff" name="attach_309532" title="MetaWaylandSurface: Don't respond to frame callback when role unassigned">attachment 309532</a> <a href="attachment.cgi?id=309532&action=edit" title="MetaWaylandSurface: Don't respond to frame callback when role unassigned">[details]</a></span> <a href='review?bug=744932&attachment=309532'>[review]</a>:
s/drawed/drawn/.
Commit message needs more motivation - what is going wrong that causes this
patch to be needed?
::: src/wayland/meta-wayland-surface.c
@@ +550,3 @@
case META_WAYLAND_SURFACE_ROLE_NONE:
+ wl_list_insert_list (&surface->frame_callback_list,
+ &pending->frame_callback_list);
Needs a comment - like "since there is no role, we won't draw the window, so
save the frame callbacks for later".
::: src/wayland/meta-wayland-surface.h
@@ +116,3 @@
+ * commit sequence, such as when it has not yet been assigned a role.
+ */
+ struct wl_list frame_callback_list;
should be 'pending_frame_callbacks' or something - if I see
surface->frame_callback_list, I would have no expectation that it's a transient
thing that is used just in some cases.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>