<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen" href="https://bugzilla.gnome.org/show_bug.cgi?id=744932#c106">Comment # 106</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen" href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a> from <a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> Jonas Ådahl</a> <pre>(In reply to Owen Taylor from <a href="show_bug.cgi?id=744932#c103">comment #103</a>) > Review of <a href="attachment.cgi?id=309537&action=diff" name="attach_309537" title="wayland: Move cursor surface role to meta-wayland-pointer.c">attachment 309537</a> <a href="attachment.cgi?id=309537&action=edit" title="wayland: Move cursor surface role to meta-wayland-pointer.c">[details]</a> <a href='review?bug=744932&attachment=309537'>[review]</a> [review]: > > Seems like code motion that simplifies. > > ::: src/wayland/meta-wayland-pointer.c > @@ +863,3 @@ > + wl_list_insert_list (&surface->compositor->frame_callbacks, > + &pending->frame_callback_list); > + wl_list_init (&pending->frame_callback_list); > > But it's really not OK to have code that modifies fields of the surface > structure scattered all over different files (probably this comment belongs > earlier in this patchset). This is not modifying the surface structure but the MetaWaylandPendingState. This is in a role-commit function, which purpose is to take what is in the pending state and apply it, so I think it needs to modify it in order to do that. Could use a helper though.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>