<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen" href="https://bugzilla.gnome.org/show_bug.cgi?id=744932#c107">Comment # 107</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen" href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a> from <a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> Jonas Ådahl</a> <pre>(In reply to Owen Taylor from <a href="show_bug.cgi?id=744932#c104">comment #104</a>) > Review of <a href="attachment.cgi?id=309535&action=diff" name="attach_309535" title="wayland: Keep what surface a surface role is associated with">attachment 309535</a> <a href="attachment.cgi?id=309535&action=edit" title="wayland: Keep what surface a surface role is associated with">[details]</a> <a href='review?bug=744932&attachment=309535'>[review]</a> [review]: > > Should have been done like this at the beginning - I'll comment on that on > this role-gobjectification patch. > > I don't see a value in private+getter instead of just putting this in the > MetaWaylandSurfaceRole structure, but then again, we've made privates pretty > efficient these days, so <shrug>, if you want to do the extra typing, it's > fine. :-) G_DECLARE_DERIVABLE_TYPE defines the MetaWaylandSuraceRole struct to be empty except for the parent, so we can't do that. It's also part of my secret plan to not have any struct definitions in the headers.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>